Skip to content

refactor: remove dead code #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

refactor: remove dead code #653

merged 1 commit into from
Nov 26, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 26, 2024 •
edited
Loading

Thanks for noticing @sommeeeer

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 2eab720

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb mentioned this pull request Nov 26, 2024
Merged
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.73% 1723 / 7577
🔵 Statements 22.73% 1723 / 7577
🔵 Functions 55.73% 102 / 183
🔵 Branches 70.73% 435 / 615
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/logger.ts 91.42% 80.64% 71.42% 91.42% 5-6, 38-40, 46
Generated in workflow #790 for commit 2eab720 by the Vitest Coverage Report Action

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 26, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@653

commit: 2eab720

sommeeeer
sommeeeer approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@sommeeeer sommeeeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicb vicb merged commit 80b24f7 into main Nov 26, 2024
3 checks passed
@vicb vicb deleted the dc branch November 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sommeeeer sommeeeer sommeeeer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @sommeeeer